Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use named Octokit import #910

Merged
merged 3 commits into from
May 20, 2020
Merged

Conversation

jlengstorf
Copy link
Contributor

- Summary

Octokit now uses named imports and prints a deprecation notice if you use the default import

[@octokit/rest] `const Octokit = require("@octokit/rest")` is deprecated. Use `const { Octokit } = require("@octokit/rest")` instead

this change swaps out to the named import to remove this deprecation notice

@erezrokah erezrokah self-requested a review May 20, 2020 10:10
@erezrokah erezrokah added the type: bug code to address defects in shipped code label May 20, 2020
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jlengstorf, I ran the tests locally and they are passing.
They are failing on your PR since the tests use a GitHub secret which is not available on PRs from forks:

NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}

We should adjust our GitHub action to consider that

@erezrokah
Copy link
Contributor

@RaeesBhatti, @jlengstorf I added another commit to sort out the tests.
A bit crude, but we can improve on it.
WDTY?

@erezrokah erezrokah added type: bug code to address defects in shipped code and removed type: bug code to address defects in shipped code labels May 20, 2020
@futuregerald futuregerald added type: bug code to address defects in shipped code and removed type: bug code to address defects in shipped code labels May 20, 2020
@RaeesBhatti RaeesBhatti merged commit dda4533 into netlify:master May 20, 2020
@RaeesBhatti
Copy link
Contributor

Thanks @erezrokah

@jlengstorf jlengstorf deleted the patch-1 branch May 20, 2020 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants