Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Netlify Dev config and docs #902

Merged
merged 13 commits into from
May 13, 2020
Merged

Conversation

RaeesBhatti
Copy link
Contributor

- Summary
Related to #898
Fixes: #901

- Test plan

- Description for the changelog

  • Improve logs in serverSettings
  • Throw error if port or targetPort are not numbers
  • Improve text description of port and targetPort
  • Log when child process exits

- A picture of a cute animal (not mandatory but encouraged)
🐰

@RaeesBhatti RaeesBhatti merged commit 3dd1cf8 into master May 13, 2020
@RaeesBhatti RaeesBhatti deleted the raees/config-improvements branch May 13, 2020 06:00
@fregante
Copy link

This is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netlify Dev exits right after outputting "Connected! Waiting for localhost:34567"
3 participants