Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix netlify dev --live #897

Merged
merged 2 commits into from
May 12, 2020
Merged

Fix netlify dev --live #897

merged 2 commits into from
May 12, 2020

Conversation

RaeesBhatti
Copy link
Contributor

- Summary
Fixes: #896

We were proxying the wrong port 🤦🏽‍♂️

- Test plan

- Description for the changelog

  • Change the port live proxy connects to from settings.proxyPort (port of the application framework server) to settings.port (port of netlify dev server)

- A picture of a cute animal (not mandatory but encouraged)
🐿

@RaeesBhatti RaeesBhatti added the type: bug code to address defects in shipped code label May 12, 2020
@RaeesBhatti RaeesBhatti requested a review from ehmicky May 12, 2020 17:54
@RaeesBhatti RaeesBhatti merged commit f430ee4 into master May 12, 2020
@RaeesBhatti RaeesBhatti deleted the raees/dev-live-fix branch May 12, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

netlify dev --live returns 404 on function invocation
2 participants