Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .env files support fo netlify dev:exec #895

Merged
merged 5 commits into from
May 11, 2020
Merged

Add .env files support fo netlify dev:exec #895

merged 5 commits into from
May 11, 2020

Conversation

RaeesBhatti
Copy link
Contributor

- Summary
Fixes: #883

- Test plan

  • Run netlify dev:exec

- Description for the changelog

  • Change getEnvFile to getEnvSettings
  • Use envSettings.{vars,file} returned from getEnvSettings instead of parsing everywhere

- A picture of a cute animal (not mandatory but encouraged)
🦄

@RaeesBhatti RaeesBhatti added the type: bug code to address defects in shipped code label May 11, 2020
@RaeesBhatti RaeesBhatti merged commit 8a0dc87 into master May 11, 2020
@RaeesBhatti RaeesBhatti deleted the raees/env-exec-fix branch May 11, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmicky ehmicky ehmicky approved these changes

@erezrokah erezrokah Awaiting requested review from erezrokah

Assignees
No one assigned
Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: netlify dev:exec does not pick up on local environment variables
2 participants
@RaeesBhatti @ehmicky