Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to unlock deployments while deploying #844

Merged
merged 5 commits into from
May 5, 2020
Merged

Allow users to unlock deployments while deploying #844

merged 5 commits into from
May 5, 2020

Conversation

RaeesBhatti
Copy link
Contributor

@RaeesBhatti RaeesBhatti commented Apr 19, 2020 •
edited
Loading

- Summary
Fixes: #182

- Test plan

- Description for the changelog

  • Add package lodash.isobject
  • Show a prompt asking you if you want to unlock deployments for your site

- A picture of a cute animal (not mandatory but encouraged)
🐼

erezrokah
erezrokah reviewed Apr 19, 2020
View reviewed changes
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we allow to publish in that case (possibly with a confirmation from the user)?
If I explicitly run a deploy command I would expect it to deploy (same as manually triggering it from the UI).

@RaeesBhatti RaeesBhatti added the type: feature code contributing to the implementation of a feature and/or user facing functionality label May 5, 2020
@RaeesBhatti RaeesBhatti changed the title Show an error if user is trying to deploy and deployment is locked Allow users to unlock deployments while deploying May 5, 2020
@RaeesBhatti RaeesBhatti merged commit 7047cfc into master May 5, 2020
@RaeesBhatti RaeesBhatti deleted the raees/error-on-lock branch May 5, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erezrokah erezrokah erezrokah left review comments

@ehmicky ehmicky Awaiting requested review from ehmicky

Assignees
No one assigned
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Paused publishing may block manual deploys
2 participants
@RaeesBhatti @erezrokah