Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect Server: Make sure "port" and 'targetPort" are not same #840

Merged
merged 2 commits into from
Apr 17, 2020
Merged

Detect Server: Make sure "port" and 'targetPort" are not same #840

merged 2 commits into from
Apr 17, 2020

Conversation

RaeesBhatti
Copy link
Contributor

- Summary
We should throw an error if port and targetPort options are same.

- Test plan
Run netlify dev -p 3000 --targetPort 3000

- Description for the changelog

  • Throw an error if specified port conflicts with specified targetPort
  • Throw an error if specified port conflicts with proxyPort provided by detector

- A picture of a cute animal (not mandatory but encouraged)
🐑

@RaeesBhatti RaeesBhatti merged commit 3b1796d into master Apr 17, 2020
@RaeesBhatti RaeesBhatti deleted the raees/port-targetPort-error branch April 17, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmicky ehmicky ehmicky approved these changes

@erezrokah erezrokah Awaiting requested review from erezrokah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RaeesBhatti @ehmicky