Dev: Add "framework" option #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we get a review on this soon please. |
ehmicky
reviewed
Apr 17, 2020
| @@ -577,7 +528,7 @@ DevCommand.flags = { | |||
| live: flags.boolean({ | |||
| char: 'l', | |||
| description: 'Start a public live session' | |||
| }) | |||
| }), | |||
There was a problem hiding this comment.
Shouldn't Prettier pick up those?
There was a problem hiding this comment.
I don't have prettier setup for oncommit hook, it messes up the staged hunks
ehmicky
reviewed
Apr 17, 2020
| for (const i in detectors) { | ||
| const detectorResult = detectors[i]() | ||
| if (detectorResult) settingsArr.push(detectorResult) | ||
| for (const i in detectors) { |
There was a problem hiding this comment.
Can also do:
for (const detector of detectors) {
const detectorResult = detector()There was a problem hiding this comment.
Is it compatible with Node 8?
ehmicky
approved these changes
Apr 17, 2020
|
Looking good except some small details! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Add
frameworkoption fornetlify.tomldevsection. This allows users to specify#autoto test all detectors,#staticto run static file server or one of project types which Netlify Dev can detect to run that detector only.This will help with situations where users have multiple detectors testing positive and they always have to choose.
Fixes: #469
Fixes: #706
Fixes: #841
- Test plan
framework = "create-react-app"or a project types which Netlify Dev can detectnetlify dev- Description for the changelog
frameworkoption fornetlify.tomlframeworkoptiontypetoframeworkin detectorsstartProxyparamserverTypetoframeworkloadDetectorfunctionchooseDefaultSettingsfunction withchooseDefaultArgsenv: { ...process.env }tosettingscratocreate-react-apprunfrom command arguments if command isnpm- A picture of a cute animal (not mandatory but encouraged)
🦄