feat: port in use #6887
Open
feat: port in use #6887
+32
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nforms the user that this could be from a netlify function opening ports Co-authored-by: Thomas Lane <tlane25@users.noreply.github.com>
Co-authored-by: Thomas Lane <163203257+tlane25@users.noreply.github.com>
DanielSLew
requested changes
Oct 19, 2024
| @@ -40,27 +40,39 @@ import { createWatchCommand } from './watch/index.js' | |||
|
|
|||
| const SUGGESTION_TIMEOUT = 1e4 | |||
|
|
|||
| process.on('uncaughtException', async (err) => { | |||
| process.on('uncaughtException', async (err: any) => { | |||
There was a problem hiding this comment.
Let's use a proper type here rather than adding in an any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
This pull request addresses these issues found below
netlify dev#6840We (@tlane25) outline the problem in the comments in #6840.
This pull request adds better error handling for users who open a port for a serverless function.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)