Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated types for sites commands #6879

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

benhancock
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes conversion to TypeScript

  • Created Account type for Netlify accounts to correspond to response issued by listAccountsForUser API endpoint
  • typed getRepoData function signature
  • Added try/catch block to api call within getTemplatesFromGithub
  • Created RepoFromGithub and Template types for fetchTemplates function

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@benhancock benhancock requested a review from a team as a code owner October 15, 2024 17:34
src/utils/types.ts Outdated Show resolved Hide resolved
@DanielSLew DanielSLew enabled auto-merge (squash) October 18, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants