Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): add missing @types/lodash dev dependency #6864

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

serhalp
Copy link
Contributor

@serhalp serhalp commented Oct 8, 2024

Because almost every package uses lodash, we always happened to have a copy of @types/lodash end up at the root of our node_modules due to a transitive dependency, so this worked out.

I confirmed this fixes that branch locally. I didn't wanna push to it unnecessarily since then Dependabot would stop auto-rebasing it and I am lazy. 😄

@serhalp serhalp requested a review from a team as a code owner October 8, 2024 19:38
@serhalp serhalp enabled auto-merge (squash) October 8, 2024 19:39
@serhalp serhalp requested review from sarahetter and removed request for sarahetter October 8, 2024 19:39
Because almost everyone uses lodash, we always happened to have a copy of @types/lodash end up at
the root of our `node_modules`, so this worked out.
@serhalp serhalp force-pushed the chore/add-missing-types-lodash branch from 88e9948 to 971054c Compare October 8, 2024 20:24
@serhalp serhalp merged commit e52e4de into main Oct 8, 2024
48 checks passed
@serhalp serhalp deleted the chore/add-missing-types-lodash branch October 8, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants