Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove prompt at the beginning of lm:setup #5976

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Conversation

kaelig
Copy link
Member

@kaelig kaelig commented Sep 1, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes an issue where the confirmation prompt introduced in #5975 was blocking invocations of lm:setup, which would be a breaking change.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@kaelig kaelig requested a review from a team as a code owner September 1, 2023 19:33
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

📊 Benchmark results

Comparing with 40b3e78

  • Dependency count: 1,331 (no change)
  • Package size: 295 MB ⬆️ 0.02% increase vs. 40b3e78

@Skn0tt
Copy link
Contributor

Skn0tt commented Sep 5, 2023

Hi! This is currently blocking main from being released, so i'll take this over and ship it :)

@Skn0tt Skn0tt merged commit 4f0cd53 into main Sep 5, 2023
64 checks passed
@Skn0tt Skn0tt deleted the kaelig/lm-remove-f branch September 5, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants