fix: fixes an issue where the --dir flag on the deploy command was broken #5966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…solving incorrectly
estephinson
approved these changes
Sep 15, 2023
eduardoboucas
approved these changes
Sep 15, 2023
lukasholzer
deleted the
fix/fixes-an-issue-where-the-deploy-folder-was-broken
branch
|
Strangely the bug regarding the Not having issues with version |
ChrisW-B
pushed a commit
to ChrisW-B/PersonalApi
that referenced
this pull request
Sep 17, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@types/twitter](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/twitter) ([source](https://github.com/DefinitelyTyped/DefinitelyTyped)) | devDependencies | patch | [`1.7.1` -> `1.7.2`](https://renovatebot.com/diffs/npm/@types%2ftwitter/1.7.1/1.7.2) | | [@types/twitter-text](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/twitter-text) ([source](https://github.com/DefinitelyTyped/DefinitelyTyped)) | devDependencies | patch | [`3.1.5` -> `3.1.6`](https://renovatebot.com/diffs/npm/@types%2ftwitter-text/3.1.5/3.1.6) | | [netlify-cli](https://github.com/netlify/cli) | devDependencies | patch | [`16.3.1` -> `16.3.3`](https://renovatebot.com/diffs/npm/netlify-cli/16.3.1/16.3.3) | --- ### Release Notes <details> <summary>netlify/cli (netlify-cli)</summary> ### [`v16.3.3`](https://github.com/netlify/cli/blob/HEAD/CHANGELOG.md#1633-2023-09-15) [Compare Source](netlify/cli@v16.3.2...v16.3.3) ##### Bug Fixes - fixes an issue where the --dir flag on the deploy command was resolving incorrectly ([#​5966](netlify/cli#5966)) ([f684887](netlify/cli@f684887)) ### [`v16.3.2`](https://github.com/netlify/cli/blob/HEAD/CHANGELOG.md#1632-2023-09-13) [Compare Source](netlify/cli@v16.3.1...v16.3.2) ##### Bug Fixes - **deps:** update netlify packages ([#​5984](netlify/cli#5984)) ([2057f88](netlify/cli@2057f88)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3pm on Sunday" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi43Ny4wIiwidXBkYXRlZEluVmVyIjoiMzYuNzcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Reviewed-on: https://git.chriswb.dev/chrisw-b/PersonalApi/pulls/7 Reviewed-by: chrisw-b <chrisw-b@noreply.localhost> Co-authored-by: Renovate Bot <renovate.bot@chrisb.xyz> Co-committed-by: Renovate Bot <renovate.bot@chrisb.xyz>
|
Also noticed this @JamesAwesome A GitHub action CI deploy command uploaded the entire monorepo to Netlify rather than just the specified Is this because it uses the workspace when set? Is that related to the |
|
@JamesAwesome, sorry for introducing this bug. It should be fixed in 16.3.4 please let us know if something is not working as expected. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #5949
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)