-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: disable flaky tests #4159
Conversation
@@ -643,7 +643,8 @@ test('should serve helpful tips and tricks', async (t) => { | |||
}) | |||
}) | |||
|
|||
test('should detect file changes to scheduled function', async (t) => { | |||
// flaky test | |||
test.skip('should detect file changes to scheduled function', async (t) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @netlify-team-account-1 as it failed randomly on all operating systems
📊 Benchmark resultsComparing with 0550e60 Package size: 360 MB(no change)
Legend
|
@erezrokah they are even more flaky now does not seem to be the solution tbh |
I'm testing #4164 to see if it helps with flakiness too (since we use less resources per machine). |
Closing this per #4164 |
🎉 Thanks for submitting a pull request! 🎉
Summary
Disable flaky tests to bring stability in our CI
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)