Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency node-fetch to 2.6.7 [security] #4115

Closed
wants to merge 4 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 22, 2022

WhiteSource Renovate

This PR contains the following updates:

Package Change
node-fetch 1.7.3 -> 2.6.7

GitHub Vulnerability Alerts

CVE-2020-15168

Impact

Node Fetch did not honor the size option after following a redirect, which means that when a content size was over the limit, a FetchError would never get thrown and the process would end without failure.

For most people, this fix will have a little or no impact. However, if you are relying on node-fetch to gate files above a size, the impact could be significant, for example: If you don't double-check the size of the data after fetch() has completed, your JS thread could get tied up doing work on a large file (DoS) and/or cost you money in computing.

Patches

We released patched versions for both stable and beta channels:

  • For v2: 2.6.1
  • For v3: 3.0.0-beta.9

Workarounds

None, it is strongly recommended to update as soon as possible.

For more information

If you have any questions or comments about this advisory:

  • Open an issue in node-fetch
  • Contact one of the core maintainers.

CVE-2022-0235

node-fetch is vulnerable to Exposure of Sensitive Information to an Unauthorized Actor


Configuration

📅 Schedule: "" (UTC).

🚦 Automerge: Disabled due to failing status checks.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner January 22, 2022 02:01
@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Jan 22, 2022
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 22, 2022
@renovate renovate bot force-pushed the renovate/npm-node-fetch-vulnerability branch from 6f5d17d to 87b2c0d Compare January 22, 2022 03:35
@renovate renovate bot changed the title chore(deps): update dependency node-fetch to v3.1.1 [security] fix(deps): update dependency node-fetch to v3.1.1 [security] Jan 22, 2022
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 22, 2022
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Jan 22, 2022
@renovate renovate bot force-pushed the renovate/npm-node-fetch-vulnerability branch from 87b2c0d to e94fbcd Compare January 22, 2022 09:12
@renovate renovate bot changed the title fix(deps): update dependency node-fetch to v3.1.1 [security] chore(deps): update dependency node-fetch to v3.1.1 [security] Jan 22, 2022
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 22, 2022
@renovate renovate bot force-pushed the renovate/npm-node-fetch-vulnerability branch from e94fbcd to bcf61d9 Compare January 22, 2022 10:06
@renovate renovate bot changed the title chore(deps): update dependency node-fetch to v3.1.1 [security] fix(deps): update dependency node-fetch to v3.1.1 [security] Jan 22, 2022
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 22, 2022
@renovate renovate bot force-pushed the renovate/npm-node-fetch-vulnerability branch from bcf61d9 to ce5c5e9 Compare January 22, 2022 11:12
@renovate renovate bot changed the title fix(deps): update dependency node-fetch to v3.1.1 [security] chore(deps): update dependency node-fetch to v3.1.1 [security] Jan 22, 2022
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 22, 2022
@renovate renovate bot force-pushed the renovate/npm-node-fetch-vulnerability branch from ce5c5e9 to eaaf908 Compare January 22, 2022 13:30
@renovate renovate bot changed the title chore(deps): update dependency node-fetch to v3.1.1 [security] fix(deps): update dependency node-fetch to v3.1.1 [security] Jan 22, 2022
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 22, 2022
@renovate renovate bot changed the title fix(deps): update dependency node-fetch to v3.1.1 [security] chore(deps): update dependency node-fetch to 2.6.1 [security] Jan 23, 2022
@renovate renovate bot changed the title chore(deps): update dependency node-fetch to 2.6.1 [security] chore(deps): update dependency node-fetch to 2.6.7 [security] Jan 24, 2022
@lukasholzer lukasholzer self-assigned this Jan 24, 2022
@github-actions
Copy link

github-actions bot commented Jan 24, 2022

📊 Benchmark results

Comparing with 68ef285

Package size: 369 MB

⬆️ 2.43% increase vs. 68ef285

^                                                                                                  369 MB 
│  357 MB  357 MB  357 MB  357 MB  357 MB  357 MB  357 MB  357 MB  357 MB  355 MB  355 MB  355 MB   ┌──┐  
│ ──┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────|▒▒|──
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 24, 2022
@XhmikosR
Copy link
Contributor

Please don't update node-fetch :/ 2.43% increase isn't worth it

None of your other deps are using 3.x and you are not yet to the point to switch to ESM modules.

@erezrokah
Copy link
Contributor

I think we're good on the security side with the 2.6.7 previous upgrades. We can upgrade to v3 if needed in a separate PR

@erezrokah erezrokah closed this Jan 25, 2022
@erezrokah erezrokah deleted the renovate/npm-node-fetch-vulnerability branch January 25, 2022 13:15
@renovate
Copy link
Contributor Author

renovate bot commented Jan 25, 2022

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will now ignore this update (2.6.7). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants