-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: disable flaky tests on windows #4101
Conversation
📊 Benchmark resultsComparing with 5ba83d8 Package size: 357 MB⬇️ 0.00% decrease vs. 5ba83d8
Legend
|
FYI @XhmikosR |
Doesn't seem to fix all failures :/ https://github.com/netlify/cli/runs/4898013668?check_suite_focus=true There must be a way to circumvent the affected tests script BTW. In this PR only a few tests ran :) |
I forgot this one updated already a pr: #4102 |
@XhmikosR why should we find a way around the affected test script? this was good that only this test was running as no others where affected by the changset. The problem is when the lockfile or the package.json is touched all tests are run as it can potentially influence all (which causes often troubles as running only few of them is not causing issues only the majority of running in paralell is causing fs issues especially on windows) |
Because in this case you couldn't test everything due to the nature of that script :) |
🎉 Thanks for submitting a pull request! 🎉
Summary
Disable flaky tests on windows:
These two where always failing and blocking
https://github.com/netlify/cli/runs/4896037137?check_suite_focus=true
I curated a list of flaky tests and those two are failing more often
https://www.notion.so/netlify/Flaky-CLI-Test-1d125bd140da4d1dbdb05ca02113d46d (internal link)
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)