chore: fixes an issue with the e2e tests

[lukasholzer]

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #4082

---

For us to review and ship your PR efficiently, please perform the following steps:

• Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
• Read the contribution guidelines 📖. This ensures your code follows our style guide and
  passes our tests.
• Update or add tests (if any source code was changed or added) 🧪
• Update or add documentation (if features were changed or added) 📝
• Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

[github-actions]

📊 Benchmark results

Comparing with 1c7eb3b

Package size: 355 MB

⬇️ 0.00% decrease vs. 1c7eb3b

^  448 MB  448 MB  448 MB  448 MB  448 MB  448 MB  448 MB  448 MB  448 MB  448 MB  448 MB  448 MB         
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐          
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |          
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |          
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |   355 MB 
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    

Legend

• T-30 (1c7eb3b): 355 MB
• T-29 (34c00bb): 355 MB
• T-28 (c421106): 355 MB
• T-27 (2b94f41): 355 MB
• T-26 (14ce2eb): 355 MB
• T-25 (1fa642e): 355 MB
• T-24 (3079e8e): 355 MB
• T-23 (898cd5a): 355 MB
• T-22 (41494be): 355 MB
• T-21 (25ef862): 355 MB
• T-20 (1c165e0): 354 MB
• T-19 (6e43165): 354 MB
• T-18 (72856c7): 354 MB
• T-17 (aedd365): 354 MB
• T-16 (7f85067): 354 MB
• T-15 (662e01b): 448 MB
• T-14 (0256222): 448 MB
• T-13 (9acf1a9): 448 MB
• T-12 (825915e): 448 MB
• T-11 (6339919): 448 MB
• T-10 (f0b31b9): 448 MB
• T-9 (417185b): 448 MB
• T-8 (6542ce2): 448 MB
• T-7 (be9cf6d): 448 MB
• T-6 (8351e25): 448 MB
• T-5 (41e6729): 448 MB
• T-4 (5e6df42): 448 MB
• T-3 (70df1b8): 448 MB
• T-2 (064049b): 448 MB
• T-1 (baafd99): 448 MB
• T (current commit): 355 MB

[lukasholzer]

now exiting with the appropriate exit code

[XhmikosR]

Shouldn't the tests fail when there are unmet peer dependencies too? https://github.com/netlify/cli/runs/4866793722?check_suite_focus=true#step:6:376

[lukasholzer]

It does not block the user (as it does not crash the install) Therefore the test should not fail.

Only if something is blocking the user it should fail the test. It's basically a safeguard so that we know if we would break something for a user :)