-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unnecessary windows cmd entry point #3850
Conversation
📊 Benchmark resultsComparing with 74cc879 Package size: 358 MB(no change)
Legend
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good 🚀
Would it make sense to test this on Windows using a release candidate or using the method described in https://github.com/netlify/pod-workflow/issues/339 using a local registry?
Also, you should change the commit message as chore:
won't generate a new release
I will do an rc version and test it out on my vm - have a parallels license now ;) |
🎉 Thanks for submitting a pull request! 🎉
Summary
remove the unnecessary file for the windows command as node generates on windows the binaries on their own. no need to ship anything
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)