Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove unused --name flag #3766

Merged
merged 2 commits into from
Dec 20, 2021
Merged

feat: remove unused --name flag #3766

merged 2 commits into from
Dec 20, 2021

Conversation

netlify-team-account-1
Copy link
Contributor

While testing #3717, I wondered what the --name flag of ntl functions:list does. Looking through the code, I can't find a single usage of the flag. Maybe it's a remnant from some copy & paste.

Technically we remove a flag, which would be a breaking change - but since it doesn't do anything, I think it's fine to assume nobody uses it. Is it still a breaking change?

@netlify-team-account-1 netlify-team-account-1 added type: feature code contributing to the implementation of a feature and/or user facing functionality area: command: functions labels Dec 3, 2021
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

📊 Benchmark results

Comparing with 16712b7

Package size: 358 MB

⬇️ 0.00% decrease vs. 16712b7

^                          363 MB  363 MB  363 MB  363 MB  363 MB  363 MB  363 MB  363 MB  363 MB  358 MB 
│  354 MB  354 MB  354 MB   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   ┌──┐    ┌──┐    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

@netlify-team-account-1
Copy link
Contributor Author

netlify-team-account-1 commented Dec 3, 2021

@lukasholzer I'll hold this PR open until #3717 is merged, so you don't get any weird conflicts because of it.

@lukasholzer
Copy link
Collaborator

@netlify-team-account-1 I will take over this and migrate it to the new commander framework

I can't find a single usage of the flag. Maybe a remnant from some copy & paste?
@netlify-team-account-1 netlify-team-account-1 requested a review from a team as a code owner December 16, 2021 14:58
@lukasholzer lukasholzer added the automerge Add to Kodiak auto merge queue label Dec 17, 2021
@lukasholzer lukasholzer requested review from erezrokah and removed request for eduardoboucas December 20, 2021 12:57
@kodiakhq kodiakhq bot merged commit 07c4bcc into main Dec 20, 2021
@kodiakhq kodiakhq bot deleted the remove-unused-name-flag branch December 20, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: command: functions automerge Add to Kodiak auto merge queue type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants