Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated bodyParser in favor of express methods #3388

Merged
merged 3 commits into from
Sep 23, 2021

Conversation

tinfoil-knight
Copy link
Contributor

- Summary

The body-parser package is not needed post express v4.17.0 as express already has the inbuilt methods as specified in the Methods section here: https://expressjs.com/en/api.html#express.

It has been replaced in the main cli package and in the function templates.

- Test plan

npx ava --verbose --serial

Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@ehmicky ehmicky added automerge Add to Kodiak auto merge queue type: chore work needed to keep the product and development running smoothly labels Sep 23, 2021
@ehmicky ehmicky merged commit 23469be into netlify:main Sep 23, 2021
@tinfoil-knight tinfoil-knight deleted the remove-bodyParser branch September 23, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants