Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace inherited log,exit utils in src/commands #3373

Merged
merged 6 commits into from
Sep 21, 2021

Conversation

tinfoil-knight
Copy link
Contributor

- Summary

#3028 was too large for review and is being broken down.

This PR is a follow-up on #3247 and uses the separate logging and process control utilities created in it to remove the inherited ones.

This PR focuses specifically on the init, login, logout, switch, watch commands in src.

- Test plan

npx ava --verbose --serial

Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@ehmicky ehmicky added automerge Add to Kodiak auto merge queue type: chore work needed to keep the product and development running smoothly labels Sep 21, 2021
@ehmicky ehmicky merged commit 29fc966 into netlify:main Sep 21, 2021
@tinfoil-knight tinfoil-knight deleted the replace-log-utils-7 branch September 22, 2021 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants