Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace inherited log, exit utils in commands.(build|env|lm|link|unlink) #3367

Merged
merged 4 commits into from
Sep 21, 2021

Conversation

tinfoil-knight
Copy link
Contributor

@tinfoil-knight tinfoil-knight commented Sep 21, 2021

- Summary

#3028 was too large for review and is being broken down.

This PR is a follow-up on #3247 and uses the separate logging and process control utilities created in it to remove the inherited ones.

This PR focuses specifically on the build, env, lm , link, unlink commands in src.

- Test plan

npx ava --verbose --serial

@tinfoil-knight tinfoil-knight changed the title refactor: replace inherited log, exit utils in commands.(env|lm|link|unlink) refactor: replace inherited log, exit utils in commands.(build|env|lm|link|unlink) Sep 21, 2021
Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label Sep 21, 2021
@ehmicky ehmicky merged commit 31587b3 into netlify:main Sep 21, 2021
@tinfoil-knight tinfoil-knight deleted the replace-log-utils-6 branch September 21, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants