refactor: replace inherited logging, exit utils in commands.functions… #3347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: chore
ehmicky
reviewed
Sep 16, 2021
src/commands/functions/create.js
Outdated
| @@ -243,7 +243,7 @@ const ensureFunctionDirExists = async function (context) { | |||
| }) | |||
|
|
|||
| log(`${NETLIFYDEVLOG} functions directory ${chalk.magenta.inverse(functionsDirHolder)} updated in site settings`) | |||
| } catch (error) { | |||
| } catch (_) { | |||
There was a problem hiding this comment.
Suggested change
| } catch (_) { | |
| } catch { |
ehmicky
reviewed
Sep 16, 2021
src/commands/functions/create.js
Outdated
| @@ -279,7 +279,7 @@ const downloadFromURL = async function (context, flags, args, functionsDir) { | |||
|
|
|||
| try { | |||
| mkdirRecursiveSync(fnFolder) | |||
| } catch (error) { | |||
| } catch (_) { | |||
There was a problem hiding this comment.
Suggested change
| } catch (_) { | |
| } catch { |
ehmicky
reviewed
Sep 16, 2021
src/commands/functions/create.js
Outdated
| @@ -365,7 +365,7 @@ const installDeps = async ({ functionPackageJson, functionPath, functionsDir }) | |||
| const functionPackageLock = path.join(functionPath, 'package-lock.json') | |||
|
|
|||
| fs.unlinkSync(functionPackageLock) | |||
| } catch (error) { | |||
| } catch (_) { | |||
There was a problem hiding this comment.
Suggested change
| } catch (_) { | |
| } catch { |
ehmicky
reviewed
Sep 16, 2021
src/commands/functions/invoke.js
Outdated
| @@ -270,7 +271,7 @@ const tryParseJSON = function (jsonString) { | |||
| if (parsedValue && typeof parsedValue === 'object') { | |||
| return parsedValue | |||
| } | |||
| } catch (error) {} | |||
| } catch (_) {} | |||
There was a problem hiding this comment.
Suggested change
| } catch (_) {} | |
| } catch {} |
ehmicky
approved these changes
Sep 16, 2021
There was a problem hiding this comment.
Thanks @tinfoil-knight, this looks great!
I just added a couple of small suggestions.
|
Hey @ehmicky, I've implemented the suggestions. Thanks for the review. The |
If you'd like to, sure! Netlify CLI supports only Node.js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
#3028 was too large for review and is being broken down.
This PR is a follow-up on #3247 and uses the separate logging and process control utilities created in it to remove the inherited ones.
This PR focuses specifically on the src/commands/functions folder. Utilities outside this folder have been changed as less as possible to avoid growing the diff size in a single PR.
- Test plan
npx ava --verbose --serialran with 1 failing test:serving-functionsSee: