fix(command-dev): pass framework-info env to sub process

src/commands/dev/index.js

@@ -61,7 +61,7 @@ const startFrameworkServer = async function ({ settings, exit }) {
   log(`${NETLIFYDEVLOG} Starting Netlify Dev with ${settings.framework || 'custom config'}`)
 
   // we use reject=false to avoid rejecting synchronously when the command doesn't exist
-  const frameworkProcess = execa.command(settings.command, { preferLocal: true, reject: false })
+  const frameworkProcess = execa.command(settings.command, { preferLocal: true, reject: false, env: settings.env })
   frameworkProcess.stdout.pipe(stripAnsiCc.stream()).pipe(process.stdout)
   frameworkProcess.stderr.pipe(stripAnsiCc.stream()).pipe(process.stderr)
   process.stdin.pipe(frameworkProcess.stdin)

src/utils/detect-server-settings.js

@@ -155,7 +155,7 @@ const getSettingsFromFramework = (framework) => {
     },
     name: frameworkName,
     staticAssetsDirectory: staticDir,
-    env,
+    env = {},
   } = framework
 
   return {

tests/framework-detection.test.js

@@ -283,3 +283,21 @@ test('should filter frameworks with no dev command', async (t) => {
     })
   })
 })
+
+test('should pass framework-info env to framework sub process', async (t) => {
+  await withSiteBuilder('site-with-gatsby', async (builder) => {
+    await builder
+      .withPackageJson({
+        packageJson: {
+          dependencies: { gatsby: '^3.0.0' },
+          scripts: { develop: 'node -p process.env.GATSBY_LOGGER' },
+        },
+      })
+      .withContentFile({ path: 'gatsby-config.js', content: '' })
+      .buildAsync()
+
+    // a failure is expected since this is not a true Gatsby project
+    const error = await t.throwsAsync(() => withDevServer({ cwd: builder.directory }, () => {}, true))
+    t.snapshot(normalize(error.stdout))
+  })
+})

tests/snapshots/framework-detection.test.js.md

@@ -223,3 +223,16 @@ Generated by [AVA](https://avajs.dev).
        └──────────────────────────────────────────────────┘␊
     ␊
     `
+
+## should pass framework-info env to framework sub process
+
+> Snapshot 1
+
+    `◈ Netlify Dev ◈␊
+    ◈ Starting Netlify Dev with Gatsby␊
+    ␊
+    > develop␊
+    > node -p process.env.GATSBY_LOGGER␊
+    ␊
+    yurnalist␊
+    ◈ "npm run develop" exited with code *. Shutting down Netlify Dev server`

tests/utils/snapshots.js

@@ -9,7 +9,7 @@ const normalizers = [
   // normalize exit code from different OSes
   { pattern: /code \d+/, value: 'code *' },
   // this is specific to npm v6
-  { pattern: /@ start.+\/.+netlify-cli-tests-v10.+/, value: 'start' },
+  { pattern: /@ (\w+?) .+\/.+netlify-cli-tests-v10.+/, value: '$1' },
   { pattern: /It should be one of.+/gm, value: 'It should be one of: *' },
 ]