fix(command-status): fix typo Github -> GitHub

[erezrokah]

- Summary

Follow up on #3022.
Made another fix to the command and added a test

- Test plan

Added a new test

- A picture of a cute animal (not mandatory but encouraged)
🐈

[github-actions]

📊 Benchmark results

Comparing with cb688df

Package size: 331 MB

(no change)

^  331 MB  331 MB  331 MB  331 MB  331 MB  331 MB  331 MB  331 MB  331 MB  331 MB  331 MB  331 MB  331 MB 
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    

Legend

• T-30 (cb688df): 331 MB
• T-29 (917b1cf): 331 MB
• T-28 (4438598): 331 MB
• T-27 (ac8a9f0): 331 MB
• T-26 (952d840): 331 MB
• T-25 (f3d433d): 331 MB
• T-24 (3b49f19): 331 MB
• T-23 (32b676d): 331 MB
• T-22 (a266401): 331 MB
• T-21 (0c25824): 331 MB
• T-20 (9e2f824): 331 MB
• T-19 (a17bf61): 331 MB
• T-18 (b3bf9db): 331 MB
• T-17 (a5fbf9c): 331 MB
• T-16 (c2ff616): 331 MB
• T-15 (95b7e3b): 331 MB
• T-14 (384d681): 331 MB
• T-13 (a9316b5): 331 MB
• T-12 (d895c34): 331 MB
• T-11 (fb61827): 331 MB
• T-10 (d863fba): 331 MB
• T-9 (e372a60): 331 MB
• T-8 (72c97d0): 331 MB
• T-7 (5c5c69b): 331 MB
• T-6 (c2ab2f0): 331 MB
• T-5 (54f636f): 331 MB
• T-4 (31ac74c): 331 MB
• T-3 (31a38ca): 331 MB
• T-2 (2d0c063): 331 MB
• T-1 (e90c153): 331 MB
• T (current commit): 331 MB

[eduardoboucas]

The snapshot test is failing. Seems to be an issue with whitespace?

[erezrokah]

The snapshot test is failing. Seems to be an issue with whitespace?

Yes! Looking into it ❤️

[erezrokah]

@eduardoboucas I fixed the test by using the --json flag. However, while doing so I realized this might be a breaking change if someone is accessing the Github property.

I'll see if we can get some data on how often its used.

[erezrokah]

@eduardoboucas I fixed the test by using the --json flag. However, while doing so I realized this might be a breaking change if someone is accessing the Github property.

I'll see if we can get some data on how often its used.

Update: the --json flag is undocumented https://cli.netlify.com/commands/status/ so I think we're safe