Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove safe-join dependency #2900

Merged
merged 2 commits into from
Jul 11, 2021
Merged

chore: remove safe-join dependency #2900

merged 2 commits into from
Jul 11, 2021

Conversation

radiantly
Copy link
Contributor

@radiantly radiantly commented Jul 11, 2021 •
edited
Loading

Closes #2896

- Summary

  • Removes the unlicensed safe-join dependency
  • Instead, we remove the leading and trailing slashes from the path

- Test plan
👀

- A picture of a cute animal (not mandatory but encouraged)
👀 👀

@erezrokah erezrokah added the type: bug code to address defects in shipped code label Jul 11, 2021
erezrokah
erezrokah suggested changes Jul 11, 2021
View reviewed changes
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @radiantly for the quick follow up on the issue.

I made a suggestion, please let me know what you think.

src/utils/read-repo-url.js Outdated Show resolved Hide resolved
erezrokah
erezrokah approved these changes Jul 11, 2021
View reviewed changes
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @radiantly! I added a test case for the parse function

@erezrokah erezrokah enabled auto-merge (squash) July 11, 2021 14:21
@erezrokah erezrokah disabled auto-merge July 11, 2021 14:42
@erezrokah erezrokah merged commit 0767251 into netlify:main Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erezrokah erezrokah erezrokah approved these changes

Assignees
No one assigned
Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove license incompatible safe-join dependency
2 participants
@radiantly @erezrokah