Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move function builders to functions lib #2811

Merged
merged 3 commits into from
Jun 30, 2021

Conversation

eduardoboucas
Copy link
Member

- Summary

Moves the function builders (netlify-lambda and zip-it-and-ship-it) to a new location, where all the JS runtime files will live.

Part of #2806.

- Test plan

N/A

@eduardoboucas eduardoboucas added the type: chore work needed to keep the product and development running smoothly label Jun 30, 2021
@eduardoboucas eduardoboucas requested a review from a team as a code owner June 30, 2021 15:26
@github-actions
Copy link

github-actions bot commented Jun 30, 2021

📊 Benchmark results

Comparing with 25a0b59

Package size: 331 MB

(no change)

^                                                          398 MB  398 MB  398 MB  398 MB  398 MB         
│                                                           ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐          
│                                                           |  |    |  |    |  |    |  |    |  |          
│ ─331 MB──331 MB──331 MB──331 MB──331 MB──331 MB──331 MB───┼──┼────┼──┼────┼──┼────┼──┼────┼──┼───331 MB─
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    |  |    |  |    |  |    |  |    |  |    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to update this section https://cli.netlify.com/netlify-dev/#function-builders-function-builder-detection-and-relationship-with-netlify-lambda with the removal of the README.

Just sharing for context

@eduardoboucas eduardoboucas enabled auto-merge (squash) June 30, 2021 15:51
@erezrokah
Copy link
Contributor

@eduardoboucas, that failing test is flaky. I'll look into it - if the PR passes on other OS I think it's ok

@eduardoboucas
Copy link
Member Author

@eduardoboucas, that failing test is flaky. I'll look into it - if the PR passes on other OS I think it's ok

I'm not in a rush to merge this, so I don't mind waiting a bit more and restarting the CI if we want to be cautious. I'll leave it up to you. Thanks for looking into it!

@eduardoboucas eduardoboucas merged commit 4d8c7e7 into main Jun 30, 2021
@eduardoboucas eduardoboucas deleted the refactor/move-function-builders branch June 30, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants