-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move function builders to functions lib #2811
Conversation
📊 Benchmark resultsComparing with 25a0b59 Package size: 331 MB(no change)
Legend
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to update this section https://cli.netlify.com/netlify-dev/#function-builders-function-builder-detection-and-relationship-with-netlify-lambda with the removal of the README.
Just sharing for context
@eduardoboucas, that failing test is flaky. I'll look into it - if the PR passes on other OS I think it's ok |
I'm not in a rush to merge this, so I don't mind waiting a bit more and restarting the CI if we want to be cautious. I'll leave it up to you. Thanks for looking into it! |
- Summary
Moves the function builders (netlify-lambda and zip-it-and-ship-it) to a new location, where all the JS runtime files will live.
Part of #2806.
- Test plan
N/A