chore(ci): pass --no-audit flag to npm #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
📊 Benchmark resultsComparing with cf6311b
|
ehmicky
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Related to #2209
Adds the
--no-auditflag tonpm ciandnpm installcommands. It's not really useful for GitHub workflows/CI.Since npm v7
npm cialso runs the audit which adds a few seconds to each installation process.See npm/cli#2703.
Also we use renovate to update dependencies and GitHub alerts us when there are security vulnerabilities, so I don't think there's much benefit to it.
- Test plan
Existing tests
- A picture of a cute animal (not mandatory but encouraged)
🦒