Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display more informative error information in TimeoutError response body #1460

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Display more informative error information in TimeoutError response body #1460

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99e271a
fix(error message): change error message to display stack and more in…
caesarsol Oct 21, 2020
7033257
fix(command-dev): improve functions error reporting and logging
erezrokah Nov 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 25 additions & 16 deletions src/utils/serve-functions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,12 @@ const { detectFunctionsBuilder } = require('./detect-functions-builder')
const { getFunctions } = require('./get-functions')
const { NETLIFYDEVLOG, NETLIFYDEVWARN, NETLIFYDEVERR } = require('./logo')

const formatLambdaLocalError = (err) => `${err.errorType}: ${err.errorMessage}\n ${err.stackTrace.join('\n ')}`

const handleErr = function (err, response) {
response.statusCode = 500
response.write(`${NETLIFYDEVERR} Function invocation failed: ${err.toString()}`)
response.end()
console.log(`${NETLIFYDEVERR} Error during invocation:`, err)
const errorString = typeof err === 'string' ? err : formatLambdaLocalError(err)
response.end(errorString)
}

const formatLambdaError = (err) => chalk.red(`${err.errorType}: ${err.errorMessage}`)
Expand All @@ -35,24 +36,32 @@ const capitalize = function (t) {
return t.replace(/(^\w|\s\w)/g, (string) => string.toUpperCase())
}

const validateLambdaResponse = (lambdaResponse) => {
if (lambdaResponse === undefined) {
return { error: 'lambda response was undefined. check your function code again' }
}
if (!Number(lambdaResponse.statusCode)) {
return {
error: `Your function response must have a numerical statusCode. You gave: $ ${lambdaResponse.statusCode}`,
}
}
if (lambdaResponse.body && typeof lambdaResponse.body !== 'string') {
return { error: `Your function response must have a string body. You gave: ${lambdaResponse.body}` }
}

return {}
}

const createSynchronousFunctionCallback = function (response) {
return function callbackHandler(err, lambdaResponse) {
if (err) {
return handleErr(err, response)
}
if (lambdaResponse === undefined) {
return handleErr('lambda response was undefined. check your function code again.', response)
}
if (!Number(lambdaResponse.statusCode)) {
console.log(
`${NETLIFYDEVERR} Your function response must have a numerical statusCode. You gave: $`,
lambdaResponse.statusCode,
)
return handleErr('Incorrect function response statusCode', response)
}
if (lambdaResponse.body && typeof lambdaResponse.body !== 'string') {
console.log(`${NETLIFYDEVERR} Your function response must have a string body. You gave:`, lambdaResponse.body)
return handleErr('Incorrect function response body', response)

const { error } = validateLambdaResponse(lambdaResponse)
if (error) {
console.log(`${NETLIFYDEVERR} ${error}`)
return handleErr(error, response)
}

response.statusCode = lambdaResponse.statusCode
Expand Down