Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: use Snyk badge for deps security #1229

Merged
merged 2 commits into from
Sep 16, 2020
Merged

README: use Snyk badge for deps security #1229

merged 2 commits into from
Sep 16, 2020

Conversation

lirantal
Copy link
Contributor

- Summary

Replacing outdated david-dm's badge with Snyk's for security insights.

- Test plan

N/A

- Description for the changelog

docs(readme): use Snyk badge for deps security

- A picture of a cute animal (not mandatory but encouraged)

@netlify
Copy link

netlify bot commented Sep 13, 2020

Deploy request for cli accepted.

Accepted with commit c3b745e

https://app.netlify.com/sites/cli/deploys/5f6124b0f9a19700073e65b6

@erezrokah erezrokah added the type: chore work needed to keep the product and development running smoothly label Sep 13, 2020
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lirantal, seems like each badge can serve a different purpose, should we keep david and add snyk?

@lirantal
Copy link
Contributor Author

It is redundant in a way, since Snyk provides both the value of security fixes, as well as general updates to keep your dependencies from a version drift.

WRT to david-dm, while I don't think there was any formal announcement, the project seems stale and out of date since 2018, with some outages happening, and the david code project itself has out of date prod and devDeps so while I haven't explored further, it seems either unmaintained or very lowly so.

What I could find is a reference such as issue 123 on https://github.com/alanshaw/david:
image

The project being unmaintained isn't a bad thing on its own though, nor do "out of date" deps a bad thing.

@erezrokah
Copy link
Contributor

It is redundant in a way, since Snyk provides both the value of security fixes, as well as general updates to keep your dependencies from a version drift.

Is there a way to relay both security vulnerabilities information and out of date dependencies information in the Snyk badge?
At the moment it only shows vulnerabilities (pending netlify/gh-release-fetch#1) which hides the dependencies information.

The project being unmaintained isn't a bad thing on its own though, nor do "out of date" deps a bad thing.

Seems like there is some in progress work to bring the project up to speed by the maintainer:
alanshaw/david#172
with alpha versions being released:
https://www.npmjs.com/package/david
https://github.com/alanshaw/david/releases

The repo for the site itself https://github.com/alanshaw/david-www needs some work, maybe it's pending alanshaw/david#172?
Don't think we suffered that much from the downtimes, but I'll probably need to look into some of these:
https://shields.io/category/dependencies
as an alternative first before switching.

@lirantal
Copy link
Contributor Author

Indeed we don't yet have a badge for out of date dependencies. It's not something to planned, so if you particularly need and want to badge this out then david-dm or alternatives. I wasn't really doing any DD on david-dm. Just browsed the repo a bit upon your ask on this and my memory of the project not being actively maintained. Good to keep as is if needed.

I can update the PR to include both david-dm and the snyk badge to get both.

@erezrokah
Copy link
Contributor

I can update the PR to include both david-dm and the snyk badge to get both.

Thank you for clarifying, until I can make a more informed decision it would be great to have both.

@lirantal
Copy link
Contributor Author

Definitely. PR updated to include both 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants