fix(docs): hide hidden command flags from docs #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
changed the title
ehmicky
approved these changes
Sep 1, 2020
ehmicky
reviewed
Sep 1, 2020
| @@ -1,4 +1,7 @@ | |||
| const path = require('path') | |||
| // This dependency is installed in `site/package.json` | |||
| // eslint-disable-next-line node/no-extraneous-require | |||
There was a problem hiding this comment.
Should we add some override in .eslintrc.json to omit that ESLint rule inside site/**?
There was a problem hiding this comment.
I think we should move this script to site/scripts, then we won't need the override/disable comment.
I'll open a new issue for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
staticServerPortflag added to thedevcommand here is shown in the docs.This PR fixes the code that generates the docs to remove hidden flags.