Remove v from node engine version string #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to install the cli with `volta install netlify-cli` failed with `error: Could not parse version ">=v8.17.0"`
|
Deploy request for cli accepted. Accepted with commit 619df08 https://app.netlify.com/sites/cli/deploys/5f46bbc2bb74b40008ab0a7a |
ehmicky
approved these changes
Aug 26, 2020
|
Looks like this was created by renovate bot https://github.com/netlify/cli/pull/994/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Trying to install the cli with Volta using
volta install netlify-clifailed witherror: Could not parse version ">=v8.17.0". Removing thevfrom the version string should fix that.- Test plan
I could install version
2.58.0without any problems and when comparing diff of 2.59.0 I noticed the node engine change that added thev.- Description for the changelog
Remove unnecessary
vfrom node engine version string.