Handle contentType not being set in netlify dev #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @yuvipanda, can we move this from draft to ready? |
`netlify dev` was failing for me consistently with the following error message: ``` ◈ Netlify Dev ◈ ◈ No app server detected and no "command" specified ◈ Using current working directory ◈ Unable to determine public folder to serve files from ◈ Setup a netlify.toml file with a [dev] section to specify your dev server settings. ◈ See docs at: https://cli.netlify.com/netlify-dev#project-detection ◈ Running static server from "mybinder.term" ◈ Server listening to 3999 ┌─────────────────────────────────────────────────┐ │ │ │ ◈ Server now ready on http://localhost:8888 │ │ │ └─────────────────────────────────────────────────┘ TypeError: Cannot read property 'endsWith' of undefined at serveRedirect (/usr/local/lib/node_modules/netlify-cli/src/commands/dev/index.js:344:16) TypeError: Cannot read property 'endsWith' of undefined at serveRedirect (/usr/local/lib/node_modules/netlify-cli/src/commands/dev/index.js:344:16) /usr/local/lib/node_modules/netlify-cli/node_modules/netlify-redirector/lib/redirects.js:116 throw ex; ^ abort({}) at Error at jsStackTrace (/usr/local/lib/node_modules/netlify-cli/node_modules/netlify-redirector/lib/redirects.js:1070:13) at stackTrace (/usr/local/lib/node_modules/netlify-cli/node_modules/netlify-redirector/lib/redirects.js:1087:12) at process.abort (/usr/local/lib/node_modules/netlify-cli/node_modules/netlify-redirector/lib/redirects.js:8502:44) at process.emit (events.js:314:20) at processPromiseRejections (internal/process/promises.js:245:33) at processTicksAndRejections (internal/process/task_queues.js:94:32) (Use `node --trace-uncaught ...` to show where the exception was thrown) ``` The code was setting `ct` to be an empty object if no content-type header was set, but then accessing `.type` on the object unconditionally. With this PR, we set `ct` to be the content-type itself, avoiding any attribute access that might cause undefined attribute access.
|
Thank you! I was putting off writing a test case - thanks for doing that :) |
erezrokah
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
netlify devwas failing for me consistently with the following error message:The code was setting
ctto be an empty object if no content-type header wasset, but then accessing
.typeon the object unconditionally. With this PR,we set
ctto be the content-type itself, avoiding any attribute access thatmight cause undefined attribute access.
- Test plan
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)