Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code urlRegexp #1045

Merged
merged 1 commit into from
Aug 2, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/detectors/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
frameworkPort: Number, // e.g. 3000
env: Object, // env variables, see examples
possibleArgsArrs: [[String]], // e.g [['run develop]], so that the combined command is 'npm run develop', but we allow for multiple
urlRegexp: RegExp, // see examples
dist: String, // static folder where a _redirect file would be placed, e.g. 'public' or 'static'. NOT the build output folder
}
```
Expand Down Expand Up @@ -56,7 +55,6 @@ module.exports = function() {
frameworkPort: 4000,
env: { ...process.env },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${4000}(/)?`, 'g'),
dist: 'public',
}
}
Expand Down
1 change: 0 additions & 1 deletion src/detectors/angular.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ module.exports = function() {
frameworkPort: 4200,
env: { ...process.env },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${4200}(/)?`, 'g'),
dist: 'dist',
}
}
1 change: 0 additions & 1 deletion src/detectors/brunch.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ module.exports = function() {
frameworkPort: 3333,
env: { ...process.env },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${3333}(/)?`, 'g'),
dist: 'app/assets',
}
}
1 change: 0 additions & 1 deletion src/detectors/create-react-app.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ module.exports = function() {
env: { ...process.env, BROWSER: 'none', PORT: 3000 },
stdio: ['inherit', 'pipe', 'pipe'],
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${3000}(/)?`, 'g'),
dist: 'public',
}
}
1 change: 0 additions & 1 deletion src/detectors/docusaurus.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ module.exports = function() {
frameworkPort: 3000,
env: { ...process.env },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${3000}(/)?`, 'g'),
dist: 'static',
}
}
1 change: 0 additions & 1 deletion src/detectors/eleventy.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ module.exports = function() {
env: { ...process.env },
command: 'npx',
possibleArgsArrs: [['eleventy', '--serve', '--watch']],
urlRegexp: new RegExp(`(http://)([^:]+:)${8080}(/)?`, 'g'),
dist: '_site',
}
}
1 change: 0 additions & 1 deletion src/detectors/ember.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ module.exports = function() {
frameworkPort: 4200,
env: { ...process.env },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${4200}(/)?`, 'g'),
dist: 'dist',
}
}
1 change: 0 additions & 1 deletion src/detectors/expo.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ module.exports = function() {
frameworkPort: 19006,
env: { ...process.env },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${19006}(/)?`, 'g'),
dist: 'web-build',
}
}
1 change: 0 additions & 1 deletion src/detectors/gatsby.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ module.exports = function() {
frameworkPort: 8000,
env: { ...process.env, GATSBY_LOGGER: 'yurnalist' },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${8000}(/)?`, 'g'),
dist: 'public',
}
}
1 change: 0 additions & 1 deletion src/detectors/gridsome.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ module.exports = function() {
frameworkPort: 8080,
env: { ...process.env },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${8080}(/)?`, 'g'),
dist: 'dist',
}
}
1 change: 0 additions & 1 deletion src/detectors/hexo.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ module.exports = function() {
frameworkPort: 4000,
env: { ...process.env },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${4000}(/)?`, 'g'),
dist: 'public',
}
}
1 change: 0 additions & 1 deletion src/detectors/hugo.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ module.exports = function() {
env: { ...process.env },
command: 'hugo',
possibleArgsArrs: [['server', '-w']],
urlRegexp: new RegExp(`(http://)([^:]+:)${1313}(/)?`, 'g'),
dist: 'public',
}
}
1 change: 0 additions & 1 deletion src/detectors/jekyll.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ module.exports = function() {
env: { ...process.env },
command: 'bundle',
possibleArgsArrs: [['exec', 'jekyll', 'serve', '-w']],
urlRegexp: new RegExp(`(http://)([^:]+:)${4000}(/)?`, 'g'),
dist: '_site',
}
}
1 change: 0 additions & 1 deletion src/detectors/middleman.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ module.exports = function() {
env: { ...process.env },
command: 'bundle',
possibleArgsArrs: [['exec', 'middleman', 'server']],
urlRegexp: new RegExp(`(http://)([^:]+:)${4567}(/)?`, 'g'),
dist: 'build',
}
}
1 change: 0 additions & 1 deletion src/detectors/next.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ module.exports = function() {
frameworkPort: 3000,
env: { ...process.env },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${3000}(/)?`, 'g'),
dist: 'out',
}
}
1 change: 0 additions & 1 deletion src/detectors/nuxt.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ module.exports = function() {
frameworkPort: 3000,
env: { ...process.env },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${3000}(/)?`, 'g'),
dist: 'dist',
}
}
1 change: 0 additions & 1 deletion src/detectors/parcel.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ module.exports = function() {
frameworkPort: 1234,
env: { ...process.env },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${1234}(/)?`, 'g'),
dist: 'dist',
}
}
1 change: 0 additions & 1 deletion src/detectors/phenomic.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ module.exports = function() {
frameworkPort: 3333,
env: { ...process.env },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${3333}(/)?`, 'g'),
dist: 'public',
}
}
1 change: 0 additions & 1 deletion src/detectors/quasar-v0.17.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ module.exports = function() {
frameworkPort: 8080,
env: { ...process.env },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${8080}(/)?`, 'g'),
dist: '.quasar',
}
}
1 change: 0 additions & 1 deletion src/detectors/quasar.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ module.exports = function() {
frameworkPort: 8081,
env: { ...process.env },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${8080}(/)?`, 'g'),
dist: '.quasar',
}
}
1 change: 0 additions & 1 deletion src/detectors/react-static.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ module.exports = function() {
frameworkPort: 3000,
env: { ...process.env },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${3000}(/)?`, 'g'),
dist: 'dist',
}
}
1 change: 0 additions & 1 deletion src/detectors/sapper.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ module.exports = function() {
frameworkPort: 3000,
env: { ...process.env },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${3000}(/)?`, 'g'),
dist: 'static',
}
}
1 change: 0 additions & 1 deletion src/detectors/stencil.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ module.exports = function() {
frameworkPort: 3333, // the port that stencil normally outputs
env: { ...process.env, BROWSER: 'none', PORT: 3000 },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${3000}(/)?`, 'g'),
dist: 'www',
}
}
1 change: 0 additions & 1 deletion src/detectors/svelte.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ module.exports = function() {
frameworkPort: 5000,
env: { ...process.env },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${5000}(/)?`, 'g'),
dist: 'public',
}
}
1 change: 0 additions & 1 deletion src/detectors/vue.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ module.exports = function() {
frameworkPort: 8080,
env: { ...process.env },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${8080}(/)?`, 'g'),
dist: 'dist',
}
}
1 change: 0 additions & 1 deletion src/detectors/vuepress.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ module.exports = function() {
frameworkPort: 8080,
env: { ...process.env },
possibleArgsArrs,
urlRegexp: new RegExp(`(http://)([^:]+:)${8080}(/)?`, 'g'),
dist: '.vuepress/dist',
}
}
1 change: 0 additions & 1 deletion src/utils/detect-server.js
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ module.exports.serverSettings = async (devConfig, flags, projectDir, log) => {
)

settings.frameworkPort = devConfig.targetPort
settings.urlRegexp = devConfig.urlRegexp || new RegExp(`(http://)([^:]+:)${devConfig.targetPort}(/)?`, 'g')
}
if (devConfig.port && devConfig.port === settings.frameworkPort) {
throw new Error(
Expand Down