-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass site or siteId to @netlify/config #1008
Conversation
src/utils/command.js
Outdated
try { | ||
return await resolveConfig({ | ||
config: argv.config, | ||
cwd: cwd, | ||
context: argv.context, | ||
debug: argv.debug, | ||
siteId: state.get('siteId'), | ||
siteId: argv.siteId || typeof argv.site === 'string' && argv.site || state.get('siteId'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any CLI flag called siteId
instead of site
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we have a site
flag in netlify deploy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a site
CLI flag in other commands as well. What about a siteId
CLI flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other site
flag is a boolean. That's why I'm checking for typeof
. We're checking for both siteId
and a string site
flag now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if argv.siteId ||
could be removed since we don't have any siteId
CLI flag at the moment?
CI tests seem to be failing due to linting. |
- Summary
Fixes: #959
- Test plan
- Description for the changelog
Use
siteId
orsite
flags assiteId
as parameters toresolveConfig
- A picture of a cute animal (not mandatory but encouraged)
🐠