Fix: Image cdn cli improvements #6189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathmbeck
commented
Nov 17, 2023
| const path = `/${modifiers}/${encodeURIComponent(url)}` | ||
| req.url = path | ||
| const sourceImagePath = url as string | ||
| const modifiers = (await transformImageParams(query)) || `_` |
There was a problem hiding this comment.
Addition of _ handles case where no transform params are provided.
kathmbeck
commented
Nov 17, 2023
| // If the image is remote, we can just pass the URL as is | ||
| req.url = `/${modifiers}/${encodeURIComponent(sourceImagePath)}` | ||
| } | ||
|
|
There was a problem hiding this comment.
This the only other functional change, uses the dev server to get the image instead of relying on the local dist directory.
5 tasks
kathmbeck
commented
Nov 17, 2023
| fit?: string | null | ||
| position?: string | null | ||
| } | ||
|
|
||
| // @ts-expect-error TS(7006) FIXME: Parameter 'config' implicitly has an 'any' type. |
There was a problem hiding this comment.
Need images on type before removing
netlify/build#5393
sarahetter
previously approved these changes
Nov 20, 2023
sarahetter
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes ADN-72
& addresses feedback to request images from local server https://netlify.slack.com/archives/C05V2MLPAFN/p1700225547575989
Also updated types in the file I was editing which ended up being most of the changes. 😄
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)