Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: images on netlify config type #5393

Merged
merged 4 commits into from
Nov 20, 2023
Merged

feat: images on netlify config type #5393

merged 4 commits into from
Nov 20, 2023

Conversation

kathmbeck
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Type needed for netlify/cli#6189


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@kathmbeck kathmbeck requested review from a team as code owners November 17, 2023 20:17
@kathmbeck kathmbeck changed the title images on netlify config type feat: images on netlify config type Nov 17, 2023
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link
Contributor

@lukasholzer lukasholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kathmbeck kathmbeck enabled auto-merge (squash) November 20, 2023 16:32
@kathmbeck kathmbeck merged commit e49cd58 into main Nov 20, 2023
36 checks passed
@kathmbeck kathmbeck deleted the images-netlify-config branch November 20, 2023 16:45
This was referenced Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants