chore(lint): add node/prefer-global/* linting rules (#1482)

.eslintrc.js

@@ -10,8 +10,17 @@ module.exports = {
     'node/no-mixed-requires': 2,
     // Browser globals should not use `require()`. Non-browser globals should
     'node/prefer-global/console': 2,
-    'node/prefer-global/text-decoder': 2,
-    'node/prefer-global/text-encoder': 2,
+    'node/prefer-global/buffer': [2, 'never'],
+    'node/prefer-global/process': [2, 'never'],
+    // TODO: enable after dropping support for Node <10.0.0
+    'node/prefer-global/url-search-params': 0,
+    'node/prefer-global/url': 0,
+    // TODO: enable after dropping support for Node <11.0.0
+    'node/prefer-global/text-decoder': 0,
+    'node/prefer-global/text-encoder': 0,
+    // TODO: enable after dropping support for Node <11.4.0
+    'node/prefer-promises/fs': 0,
+    'node/prefer-promises/dns': 0,
     // This does not work well in a monorepo
     'node/shebang': 0,
 
@@ -20,10 +29,6 @@ module.exports = {
     // 'node/no-sync': 2,
     // 'node/callback-return': 2,
     // 'node/global-require': 2,
-    // 'node/prefer-global/url-search-params': 2,
-    // 'node/prefer-global/url': 2,
-    // 'node/prefer-global/buffer': [2, 'never'],
-    // 'node/prefer-global/process': [2, 'never'],
 
     // TODO: harmonize with filename snake_case in other Netlify Dev projects
     'unicorn/filename-case': [2, { case: 'kebabCase', ignore: ['.*.md'] }],

scripts/run-on-error.js

@@ -1,9 +1,9 @@
 #!/usr/bin/env node
-const { argv } = require('process')
+const process = require('process')
 
 const execa = require('execa')
 
-const [, , npmScript, npmScriptOnError] = argv
+const [, , npmScript, npmScriptOnError] = process.argv
 
 // Run a npm script. If that script fails, another npm script is run.
 // We use this for example with ESLint and Prettier to be able to fail if

site/scripts/docs.js

@@ -1,4 +1,5 @@
 const path = require('path')
+const process = require('process')
 
 const markdownMagic = require('markdown-magic')
 const stripAnsi = require('strip-ansi')

src/commands/build/index.js

@@ -1,3 +1,5 @@
+const process = require('process')
+
 const { flags } = require('@oclif/command')
 
 const { getBuildOptions, runBuild } = require('../../lib/build')

src/commands/deploy.js

@@ -1,4 +1,5 @@
 const path = require('path')
+const process = require('process')
 
 const { flags: flagsLib } = require('@oclif/command')
 const chalk = require('chalk')

src/commands/dev/index.js

@@ -1,5 +1,6 @@
 const childProcess = require('child_process')
 const path = require('path')
+const process = require('process')
 
 const { flags: flagsLib } = require('@oclif/command')
 const boxen = require('boxen')

src/commands/functions/build.js

@@ -1,4 +1,5 @@
 const fs = require('fs')
+const process = require('process')
 
 const { zipFunctions } = require('@netlify/zip-it-and-ship-it')
 const { flags: flagsLib } = require('@oclif/command')

src/commands/functions/create.js

@@ -1,6 +1,7 @@
 const cp = require('child_process')
 const fs = require('fs')
 const path = require('path')
+const process = require('process')
 
 const { flags: flagsLib } = require('@oclif/command')
 const chalk = require('chalk')

src/commands/functions/invoke.js

@@ -1,5 +1,6 @@
 const fs = require('fs')
 const path = require('path')
+const process = require('process')
 
 const { flags: flagsLib } = require('@oclif/command')
 const chalk = require('chalk')

src/commands/functions/list.js

@@ -1,3 +1,5 @@
+const process = require('process')
+
 const { flags: flagsLib } = require('@oclif/command')
 const AsciiTable = require('ascii-table')
 

src/commands/link.js

@@ -1,4 +1,5 @@
 const path = require('path')
+const process = require('process')
 
 const { flags: flagsLib } = require('@oclif/command')
 const chalk = require('chalk')

src/functions-templates/js/fauna-crud/create-schema.js

@@ -1,4 +1,5 @@
 #!/usr/bin/env node
+const process = require('process')
 
 /* bootstrap database in your FaunaDB account - use with `netlify dev:exec <path-to-this-file>` */
 const { query, Client } = require('faunadb')

src/functions-templates/js/fauna-crud/create.js

@@ -1,3 +1,5 @@
+const process = require('process')
+
 const { query, Client } = require('faunadb')
 
 /* configure faunaDB Client with our secret */

src/functions-templates/js/fauna-crud/delete.js

@@ -1,4 +1,6 @@
 /* Import faunaDB sdk */
+const process = require('process')
+
 const { query, Client } = require('faunadb')
 
 const client = new Client({

src/functions-templates/js/fauna-crud/read-all.js

@@ -1,4 +1,6 @@
 /* Import faunaDB sdk */
+const process = require('process')
+
 const { query, Client } = require('faunadb')
 
 const client = new Client({

src/functions-templates/js/fauna-crud/read.js

@@ -1,4 +1,6 @@
 /* Import faunaDB sdk */
+const process = require('process')
+
 const { query, Client } = require('faunadb')
 
 const client = new Client({

src/functions-templates/js/fauna-crud/update.js

@@ -1,4 +1,6 @@
 /* Import faunaDB sdk */
+const process = require('process')
+
 const { query, Client } = require('faunadb')
 
 const client = new Client({

src/functions-templates/js/fauna-graphql/fauna-graphql.js

@@ -1,3 +1,6 @@
+const { Buffer } = require('buffer')
+const process = require('process')
+
 const { createHttpLink } = require('apollo-link-http')
 const { ApolloServer } = require('apollo-server-lambda')
 const { introspectSchema, makeRemoteExecutableSchema } = require('graphql-tools')

src/functions-templates/js/fauna-graphql/sync-schema.js

@@ -1,4 +1,6 @@
 #!/usr/bin/env node
+const { Buffer } = require('buffer')
+const process = require('process')
 
 /* sync GraphQL schema to your FaunaDB account - use with `netlify dev:exec <path-to-this-file>` */
 const createFaunaGraphQL = function () {

src/functions-templates/js/graphql-gateway/graphql-gateway.js

@@ -4,6 +4,7 @@
  *
  * Of course, feel free to modify this gateway to suit your needs.
  */
+const process = require('process')
 
 const { createHttpLink } = require('apollo-link-http')
 const { ApolloServer } = require('apollo-server-lambda')

src/functions-templates/js/oauth-passport/utils/config.js

@@ -1,6 +1,8 @@
 // lambda/utils/config.js
 // Circumvent problem with Netlify CLI.
 // https://github.com/netlify/netlify-dev-plugin/issues/147
+const process = require('process')
+
 const BASE_URL = process.env.NODE_ENV === 'development' ? 'http://localhost:8888' : process.env.BASE_URL
 
 const COOKIE_SECURE = process.env.NODE_ENV !== 'development'

src/functions-templates/js/sanity-create/sanity-create.js

@@ -1,3 +1,5 @@
+const process = require('process')
+
 const sanityClient = require('@sanity/client')
 
 // You will need to configure environment variables for Sanity.io project id,

src/functions-templates/js/sanity-groq/sanity-groq.js

@@ -1,3 +1,5 @@
+const process = require('process')
+
 const sanityClient = require('@sanity/client')
 
 // You will need to configure environment variables for Sanity.io project id

src/functions-templates/js/send-email/send-email.js

@@ -1,4 +1,6 @@
 // with thanks to https://github.com/Urigo/graphql-modules/blob/8cb2fd7d9938a856f83e4eee2081384533771904/website/lambda/contact.js
+const process = require('process')
+
 const sendMail = require('sendmail')()
 
 const { validateEmail, validateLength } = require('./validations')

src/functions-templates/js/serverless-ssr/app/index.js

@@ -1,4 +1,6 @@
 /* Express App */
+const process = require('process')
+
 const bodyParser = require('body-parser')
 const compression = require('compression')
 const cors = require('cors')

src/functions-templates/js/slack-rate-limit/slack-rate-limit.js

@@ -1,6 +1,8 @@
 // code walkthrough: https://www.netlify.com/blog/2018/03/29/jamstack-architecture-on-netlify-how-identity-and-functions-work-together/#updating-user-data-with-the-identity-api
 // demo repo: https://github.com/biilmann/testing-slack-tutorial/tree/v3-one-message-an-hour
 // note: requires SLACK_WEBHOOK_URL environment variable
+const process = require('process')
+
 const slackURL = process.env.SLACK_WEBHOOK_URL
 const fetch = require('node-fetch')
 

src/functions-templates/js/stripe-charge/stripe-charge.js

@@ -1,4 +1,5 @@
 // with thanks https://github.com/alexmacarthur/netlify-lambda-function-example/blob/68a0cdc05e201d68fe80b0926b0af7ff88f15802/lambda-src/purchase.js
+const process = require('process')
 
 const stripe = require('stripe')(process.env.STRIPE_SECRET_KEY)
 

src/functions-templates/js/stripe-subscription/stripe-subscription.js

@@ -1,4 +1,5 @@
 // with thanks https://github.com/LukeMwila/stripe-subscriptions-backend/blob/master/stripe-api/index.ts
+const process = require('process')
 
 const stripe = require('stripe')(process.env.STRIPE_SECRET_KEY)
 

src/functions-templates/js/submission-created/submission-created.js

@@ -2,6 +2,8 @@
 // require('dotenv').config()
 
 // // details in https://css-tricks.com/using-netlify-forms-and-netlify-functions-to-build-an-email-sign-up-widget
+const process = require('process')
+
 const fetch = require('node-fetch')
 const { EMAIL_TOKEN } = process.env
 const handler = async (event) => {

src/functions-templates/js/token-hider/token-hider.js

@@ -1,3 +1,5 @@
+const process = require('process')
+
 const axios = require('axios')
 const qs = require('qs')
 

src/functions-templates/js/url-shortener/generate-route.js

@@ -1,4 +1,5 @@
 'use strict'
+const process = require('process')
 
 const Hashids = require('hashids')
 const request = require('request')

src/functions-templates/js/url-shortener/get-route.js

@@ -1,4 +1,5 @@
 'use strict'
+const process = require('process')
 
 const request = require('request')
 

src/hooks/init.js

@@ -1,3 +1,5 @@
+const process = require('process')
+
 const envinfo = require('envinfo')
 
 const globalConfig = require('../utils/global-config')

src/lib/exec-fetcher.js

@@ -1,4 +1,5 @@
 const path = require('path')
+const process = require('process')
 
 const execa = require('execa')
 const { fetchVersion, fetchLatest, updateAvailable, newerVersion } = require('gh-release-fetch')

src/lib/exec-fetcher.test.js

@@ -1,4 +1,5 @@
 const path = require('path')
+const process = require('process')
 
 const test = require('ava')
 const tempDirectory = require('temp-dir')

src/lib/http-agent.test.js

@@ -1,4 +1,5 @@
 const http = require('http')
+const process = require('process')
 
 const test = require('ava')
 const { createProxyServer } = require('http-proxy')

src/utils/command.js

@@ -1,3 +1,4 @@
+const process = require('process')
 const { URL } = require('url')
 const { format, inspect } = require('util')
 

src/utils/create-stream-promise.js

@@ -1,3 +1,5 @@
+const { Buffer } = require('buffer')
+
 const createStreamPromise = function (stream, timeoutSeconds, bytesLimit = DEFAULT_BYTES_LIMIT) {
   return new Promise(function streamPromiseFunc(resolve, reject) {
     let data = []

src/utils/detect-server.js

@@ -1,5 +1,6 @@
 const fs = require('fs')
 const path = require('path')
+const process = require('process')
 
 const chalk = require('chalk')
 const fuzzy = require('fuzzy')

src/utils/detect-server.test.js

@@ -1,4 +1,5 @@
 const path = require('path')
+const process = require('process')
 
 const test = require('ava')
 const getPort = require('get-port')

src/utils/dev.js

@@ -1,5 +1,7 @@
 // reusable code for netlify dev
 // bit of a hasty abstraction but recommended by oclif
+const process = require('process')
+
 const chalk = require('chalk')
 
 const {

src/utils/env.js

@@ -1,6 +1,6 @@
 // dotenv loading similar to create-react-app / react-scripts or dotenv-load
-
 const path = require('path')
+const process = require('process')
 
 const dotenv = require('dotenv')
 const filterObject = require('filter-obj')

src/utils/env.test.js

@@ -1,3 +1,5 @@
+const process = require('process')
+
 const test = require('ava')
 const sinon = require('sinon')
 

src/utils/get-repo-data.js

@@ -1,4 +1,5 @@
 const path = require('path')
+const process = require('process')
 const util = require('util')
 
 const findUp = require('find-up')

src/utils/gh-auth.js

@@ -1,5 +1,6 @@
 // A simple ghauth inspired library for getting a personal access token
 const http = require('http')
+const process = require('process')
 const querystring = require('querystring')
 
 const { Octokit } = require('@octokit/rest')

src/utils/live-tunnel.js

@@ -1,3 +1,5 @@
+const process = require('process')
+
 const chalk = require('chalk')
 const execa = require('execa')
 const fetch = require('node-fetch')

src/utils/open-browser.js

@@ -1,3 +1,5 @@
+const process = require('process')
+
 const chalk = require('chalk')
 const isDockerContainer = require('is-docker')
 const open = require('open')

src/utils/proxy.js

@@ -1,3 +1,4 @@
+const { Buffer } = require('buffer')
 const http = require('http')
 const path = require('path')
 const { URL, URLSearchParams } = require('url')

src/utils/serve-functions.js

@@ -1,3 +1,4 @@
+const { Buffer } = require('buffer')
 const querystring = require('querystring')
 const { Readable } = require('stream')
 const { URL } = require('url')

src/utils/state-config.js

@@ -1,5 +1,6 @@
 const fs = require('fs')
 const path = require('path')
+const process = require('process')
 
 const dotProp = require('dot-prop')
 const findUp = require('find-up')

src/utils/telemetry/index.js

@@ -1,5 +1,6 @@
 const { spawn } = require('child_process')
 const path = require('path')
+const process = require('process')
 
 const ci = require('ci-info')
 

src/utils/telemetry/request.js

@@ -1,4 +1,6 @@
 // Spawn a detached process
+const process = require('process')
+
 const fetch = require('node-fetch')
 const options = JSON.parse(process.argv[2])
 

src/utils/traffic-mesh.js

@@ -1,4 +1,5 @@
 const path = require('path')
+const process = require('process')
 
 const execa = require('execa')
 const waitPort = require('wait-port')

tests/command.addons.test.js

@@ -1,3 +1,5 @@
+const process = require('process')
+
 const test = require('ava')
 
 const callCli = require('./utils/call-cli')

tests/command.deploy.test.js

@@ -1,3 +1,5 @@
+const process = require('process')
+
 const test = require('ava')
 const fetch = require('node-fetch')
 const omit = require('omit.js').default

tests/command.dev.exec.test.js

@@ -1,3 +1,5 @@
+const process = require('process')
+
 const test = require('ava')
 
 const callCli = require('./utils/call-cli')