refactor: replace catch(_) with catch in try-catch blocks (#3350)

scripts/postinstall.js

@@ -9,7 +9,7 @@ const format = (message, styles) => {
     styles.forEach((style) => {
       func = func[style]
     })
-  } catch (_) {}
+  } catch {}
   return func(message)
 }
 

site/fs.js

@@ -9,7 +9,7 @@ const rimrafAsync = util.promisify(rimraf)
 const copyDirRecursiveAsync = async (src, dest) => {
   try {
     fs.mkdir(dest, { recursive: true })
-  } catch (_) {
+  } catch {
     // ignore erros for mkdir
   }
 
@@ -34,7 +34,7 @@ const copyDirRecursiveAsync = async (src, dest) => {
 const ensureFilePathAsync = async (filePath) => {
   try {
     await fs.mkdir(path.dirname(filePath), { recursive: true })
-  } catch (_) {
+  } catch {
     // ignore any errors with mkdir - it will throw if the path already exists.
   }
 }

src/commands/lm/info.js

@@ -25,7 +25,7 @@ class LmInfoCommand extends Command {
     const tasks = new Listr(steps, { concurrent: true, exitOnError: false })
     try {
       await tasks.run()
-    } catch (_) {
+    } catch {
       // an error is already reported when a task fails
     }
   }

src/lib/fs.js

@@ -26,7 +26,7 @@ const fileExistsAsync = async (filePath) => {
   try {
     await accessAsync(filePath, fs.F_OK)
     return true
-  } catch (_) {
+  } catch {
     return false
   }
 }

src/lib/functions/runtimes/go/index.js

@@ -31,7 +31,7 @@ const checkGoInstallation = async ({ cwd }) => {
     await execa('go', ['version'], { cwd })
 
     return true
-  } catch (_) {
+  } catch {
     return false
   }
 }

src/lib/functions/server.js

@@ -33,7 +33,7 @@ const buildClientContext = function (headers) {
       },
       user: jwtDecode(parts[1]),
     }
-  } catch (_) {
+  } catch {
     // Ignore errors - bearer token is not a JWT, probably not intended for us
   }
 }

src/utils/command.js

@@ -123,7 +123,7 @@ class BaseCommand extends TrackedCommand {
     try {
       await this.netlify.api.getCurrentUser()
       return true
-    } catch (_) {
+    } catch {
       return false
     }
   }

src/utils/get-global-config.js

@@ -20,7 +20,7 @@ const getGlobalConfigOnce = async function () {
   // Read legacy config if exists
   try {
     legacyConfig = JSON.parse(await readFileAsync(legacyPath))
-  } catch (_) {}
+  } catch {}
   // Use legacy config as default values
   const defaults = { ...globalConfigDefaults, ...legacyConfig }
   const configStore = new Configstore(null, defaults, { configPath })

src/utils/get-global-config.test.js

@@ -22,7 +22,7 @@ const tmpConfigBackupPath = path.join(os.tmpdir(), `netlify-config-backup-${Date
 test.before('backup current user config if exists', async () => {
   try {
     await copyFileAsync(configPath, tmpConfigBackupPath)
-  } catch (_) {}
+  } catch {}
 })
 
 test.after.always('cleanup tmp directory and legacy config', async () => {
@@ -32,7 +32,7 @@ test.after.always('cleanup tmp directory and legacy config', async () => {
     await copyFileAsync(tmpConfigBackupPath, configPath)
     // Remove tmp backup if exists
     await rmFileAsync(tmpConfigBackupPath)
-  } catch (_) {}
+  } catch {}
   // Remove legacy config path
   await rmdirRecursiveAsync(getLegacyPathInHome([]))
 })

src/utils/init/config-github.js

@@ -84,7 +84,7 @@ const hookExists = async ({ deployHook, octokit, repoOwner, repoName }) => {
     })
     const exists = hooks.some((hook) => hook.config.url === deployHook)
     return exists
-  } catch (_) {
+  } catch {
     // we don't need to fail if listHooks errors out
     return false
   }

src/utils/lm/install.js

@@ -274,7 +274,7 @@ const cleanupShell = async function () {
     }
 
     await removeConfig(configFile, getInitContent(incFilePath))
-  } catch (_) {}
+  } catch {}
 }
 
 const uninstall = async function () {

tests/serving-functions.test.js

@@ -347,7 +347,7 @@ testMatrix.forEach(({ args }) => {
                   const response = await got(`http://localhost:${port}/.netlify/functions/hello`).text()
 
                   return response === 'Hello'
-                } catch (_) {
+                } catch {
                   return false
                 }
               },
@@ -429,7 +429,7 @@ export { handler }
                   const response = await got(`http://localhost:${port}/.netlify/functions/hello`).text()
 
                   return response === 'Modern Web Development on the Jamstack'
-                } catch (_) {
+                } catch {
                   return false
                 }
               },
@@ -539,7 +539,7 @@ export { handler }
                   const response = await got(`http://localhost:${port}/.netlify/functions/hello`).text()
 
                   return response === 'Internal updated'
-                } catch (_) {
+                } catch {
                   return false
                 }
               },
@@ -613,7 +613,7 @@ export { handler }
                   const response = await got(`http://localhost:${port}/.netlify/functions/hello`).text()
 
                   return response === 'User updated'
-                } catch (_) {
+                } catch {
                   return false
                 }
               },