chore: add basic erlang detection via rebar #5886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
approved these changes
Oct 16, 2024
| export class Erlang extends LangRuntime { | ||
| id = 'erlang' | ||
| name = 'Erlang' | ||
| configFiles = ['rebar.config', 'rebar.lock'] |
There was a problem hiding this comment.
My quick research says a nontrivial fraction of Erlang projects won't be using Rebar. As long as that's ok, this seems fine 🤷🏼♂️.
There was a problem hiding this comment.
Yes, I meant for this to serve as a starting point for us. I don't personally know of any other markers to check for, but if you happen to know any, let's add them!
serhalp
approved these changes
Oct 16, 2024
mrstork
force-pushed
the
chore/erlang-detection
branch
from
10fd6ce
to
ae3c0fe
Compare
mrstork
force-pushed
the
chore/erlang-detection
branch
from
ae3c0fe
to
a7d9eaf
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Rebar is a very common Erlang build tool (see: https://github.com/erlang/rebar3)
Using the rebar config files to detect some erlang usage in Netlify
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)