fix: stop changing logs if flusher is not set
#5676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request adds or modifies JavaScript ( |
eduardoboucas
commented
May 27, 2024
| @@ -190,7 +190,7 @@ export const getSystemLogger = function ( | |||
| return (...args) => fileDescriptor.write(`${reduceLogLines(args)}\n`) | |||
| } | |||
|
|
|||
| export const addOutputGate = (logs: Logs, outputFlusher: OutputFlusher): Logs => { | |||
| export const addOutputFlusher = (logs: Logs, outputFlusher: OutputFlusher): Logs => { | |||
There was a problem hiding this comment.
Just renaming the method here to be consistent with the naming we ended up choosing. No functional change.
JGAntunes
approved these changes
May 27, 2024
This was referenced Jun 5, 2024
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If
outputFlusherisn't set, stop changing thelogsreference that is sent to the logic that calls plugins.This shouldn't make a difference, but trying to be super defensive about this code path.