-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pass zipGo
property to ZISI
#4058
Conversation
@@ -24,6 +24,7 @@ const normalizeFunctionConfig = ({ buildDir, functionConfig = {}, isRunningLocal | |||
includedFiles: functionConfig.included_files, | |||
includedFilesBasePath: buildDir, | |||
ignoredNodeModules: functionConfig.ignored_node_modules, | |||
schedule: functionConfig.schedule, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be added to @netlify/config
too?
build/packages/config/src/functions_config.js
Lines 50 to 57 in fb173c0
export const FUNCTION_CONFIG_PROPERTIES = new Set([ 'directory', 'external_node_modules', 'ignored_node_modules', 'included_files', 'node_bundler', 'schedule', ]) - And
build/packages/config/src/validate/validations.js
Lines 220 to 227 in fb173c0
{ property: 'functions.*.directory', check: (value, key, prevPath) => prevPath[1] === FUNCTIONS_CONFIG_WILDCARD_ALL, message: 'must be defined on the main `functions` object.', example: () => ({ functions: { directory: 'my-functions' }, }), }, - Potentially also
build/packages/functions-utils/tests/main.js
Lines 110 to 114 in fb173c0
const normalizeFiles = function (fixtureDir, { name, mainFile, runtime, extension, srcFile, schedule }) { const mainFileA = normalize(`${fixtureDir}/${mainFile}`) const srcFileA = srcFile === undefined ? {} : { srcFile: normalize(`${fixtureDir}/${srcFile}`) } return { name, mainFile: mainFileA, runtime, extension, schedule, ...srcFileA } }
Edit: Oops, disregard this comment. I realized this configuration is only set by us, not by users. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Summary
Passes the
zipGo
configuration option to zip-it-and-ship-it (added in netlify/zip-it-and-ship-it#955) when running locally.A picture of a cute animal (not mandatory, but encouraged)