Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Fix Rust caching issues #521

Merged
merged 5 commits into from
Jan 14, 2021
Merged

Fix Rust caching issues #521

merged 5 commits into from
Jan 14, 2021

Conversation

calavera
Copy link
Contributor

@calavera calavera commented Jan 12, 2021 •
edited
Loading

Fixes #508
Fixes #505

@calavera
Cache rust artifacts only when cargo files are detected
3740589 
This way we don't turn the `target` directory into a reserved directory if people are not using rust.
@calavera calavera added the type: bug code to address defects in shipped code label Jan 12, 2021
@calavera calavera requested a review from a team as a code owner January 12, 2021 18:09
vbrown608
vbrown608 reviewed Jan 12, 2021
View reviewed changes
run-build-functions.sh Outdated Show resolved Hide resolved
calavera and others added 3 commits January 12, 2021 10:27
@calavera @vbrown608
Update run-build-functions.sh
f009c3b 
Co-authored-by: Vivian Brown <vivian@netlify.com>
@calavera
Cache the target directory only when a cargo file exists.
4dbcb17 
Signed-off-by: David Calavera <david.calavera@gmail.com>
@calavera
Copy target directory using reflinks.
ebc2ba7 
This allows keeping both directories until the deploy is completed,
while keeping the fast nature of moving things around.

Signed-off-by: David Calavera <david.calavera@gmail.com>
@calavera calavera changed the title Cache rust artifacts only when cargo files are detected Fix Rust caching issues Jan 12, 2021
@calavera calavera mentioned this pull request Jan 12, 2021
Open
@calavera
Copy link
Contributor Author

I've opted for changing only the behavior of how we cache the target directory, instead of all cached directories to minimize the impact of these changes.

@calavera
Copy link
Contributor Author

@vbrown608 I've tested this with an internal build and it seems to work as expected

mraerino
mraerino reviewed Jan 13, 2021
View reviewed changes
run-build-functions.sh Outdated Show resolved Hide resolved
@calavera
Cache .rustup regardless of whether there are cargo files or not.
4d33fdd 
Signed-off-by: David Calavera <david.calavera@gmail.com>
mraerino
mraerino approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@mraerino mraerino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@calavera calavera merged commit d84c794 into xenial Jan 14, 2021
@calavera calavera deleted the fix_rust_cache branch January 14, 2021 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vbrown608 vbrown608 vbrown608 approved these changes

@mraerino mraerino mraerino approved these changes

Assignees
No one assigned
Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
3 participants
@calavera @vbrown608 @mraerino