This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Add Prep functions build function #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcomnes
force-pushed
the
move-zisi-to-build
branch
from
8fc44e0
to
1fb3a20
Compare
bcomnes
commented
May 2, 2019
|
This is ready to go. |
bcomnes
force-pushed
the
move-zisi-to-build
branch
3 times, most recently
from
6593c16
to
c1ac7bd
Compare
sgirones
reviewed
May 7, 2019
sgirones
reviewed
May 7, 2019
bcomnes
force-pushed
the
move-zisi-to-build
branch
from
c1ac7bd
to
89e20b8
Compare
This enables one to run ZISI from the build step.
bcomnes
force-pushed
the
move-zisi-to-build
branch
from
89e20b8
to
23b55c2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a prep functions step to run_build functions, which we can run to prepare functions with zip-it-and-ship-it from inside the build environment, enabling fancier build and dependency installs.
This is an alternative implementation from having separate buildbot stages, so that we can improve our bundling experience with the users build environment.