Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Report lingering processes to the user #202

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Conversation

sgirones
Copy link
Contributor

@sgirones sgirones commented Oct 1, 2018

Netlify builds will wait until all the processes finish. If they don't finish, the build will eventually timeout and will be marked as failed.

This code will detect and report any lingering process after the main build command finishes so the user can make sure they are terminated properly.

@bcomnes bcomnes self-assigned this Nov 9, 2018
@bcomnes
Copy link
Contributor

bcomnes commented Nov 13, 2018

I'm going to rebase and see if that fixes the builds.

@bcomnes
Copy link
Contributor

bcomnes commented Nov 13, 2018

Oh wait, there is no place to rebase too 🤔

@bcomnes
Copy link
Contributor

bcomnes commented Nov 13, 2018

Seems like there are some dependency issues to resolve first. Fixing those, then we'll rebase this.

@bcomnes
Copy link
Contributor

bcomnes commented Nov 15, 2018

Rebased, and rebuilding.

@bcomnes bcomnes merged commit c136bcb into master Nov 15, 2018
@bcomnes bcomnes deleted the detect-lingering-procs branch November 15, 2018 00:36
@bcomnes
Copy link
Contributor

bcomnes commented Nov 15, 2018

screen shot 2018-11-14 at 5 34 44 pm

Looks like its working! Not sure what that huge string is though. @sgirones any ideas?

https://app.netlify.com/sites/test-deploy-site/deploys/5becccf5792f8919f659786a

@sgirones
Copy link
Contributor Author

sgirones commented Nov 15, 2018

That's the buildbot process itself. We should exclude it from the list of processes

I tested the code locally, so buildbot was not running in my container

How did you test it? Did that build have a lingering process?

@sgirones
Copy link
Contributor Author

Nevermind, I saw your new PR

@bcomnes
Copy link
Contributor

bcomnes commented Nov 15, 2018

It was a null test with no lingering process. I'll perform a test with a lingering process, but after I filter out the build bot itself.

@verythorough verythorough added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-review type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants