-
Notifications
You must be signed in to change notification settings - Fork 196
Report lingering processes to the user #202
Conversation
I'm going to rebase and see if that fixes the builds. |
Oh wait, there is no place to rebase too 🤔 |
Seems like there are some dependency issues to resolve first. Fixing those, then we'll rebase this. |
bc0be2e
to
b3d65d7
Compare
Rebased, and rebuilding. |
Looks like its working! Not sure what that huge string is though. @sgirones any ideas? https://app.netlify.com/sites/test-deploy-site/deploys/5becccf5792f8919f659786a |
That's the buildbot process itself. We should exclude it from the list of processes I tested the code locally, so buildbot was not running in my container How did you test it? Did that build have a lingering process? |
Nevermind, I saw your new PR |
It was a null test with no lingering process. I'll perform a test with a lingering process, but after I filter out the build bot itself. |
Netlify builds will wait until all the processes finish. If they don't finish, the build will eventually timeout and will be marked as failed.
This code will detect and report any lingering process after the main build command finishes so the user can make sure they are terminated properly.