Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Update build-image to match current defaults for new sites #130

Merged
merged 1 commit into from
Feb 5, 2018
Merged

Update build-image to match current defaults for new sites #130

merged 1 commit into from
Feb 5, 2018

Conversation

brycekahle
Copy link
Contributor

@brycekahle brycekahle commented Feb 5, 2018 •
edited
Loading

Fixes #128

I'm curious if we should update Ruby as well, 2.2 is planned to be EOL on 2018-03-31.

@brycekahle brycekahle requested review from fool and rybit February 5, 2018 17:31
@brycekahle
Copy link
Contributor Author

brycekahle commented Feb 5, 2018 •
edited
Loading

For existing sites using 0.18.1 that need the --ignore-optional flag, we could set that env var for them in the database, if they do not have an existing YARN_FLAGS.

@rybit
Copy link
Member

rybit commented Feb 5, 2018

lgtm

we need to do the database thingy first

fool
fool reviewed Feb 5, 2018
View reviewed changes
Copy link
Contributor

@fool fool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want a small blog post on updated versions since we're also updating node.

@brycekahle
Copy link
Contributor Author

We decide to use a code-based approach in the API. No database changes required.

@brycekahle brycekahle merged commit bc27b5c into master Feb 5, 2018
@brycekahle brycekahle deleted the update-yarn branch February 5, 2018 22:27
@brycekahle brycekahle mentioned this pull request Feb 6, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fool fool fool left review comments

@rybit rybit Awaiting requested review from rybit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brycekahle @rybit @fool