Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Simplify logic using || instead of negated if #107

Merged
merged 1 commit into from
Dec 10, 2017

Conversation

aureliojargas
Copy link
Contributor

Shorter and easier to read.

@aureliojargas
Copy link
Contributor Author

aureliojargas commented Nov 21, 2017

Using the test command explicitly it would be even more readable, since the square brackets are gone:

test -f $1 || return 0
test -f $3 || return 0

But now it enters personal preference land :)

@calavera
Copy link
Contributor

lgtm

@calavera calavera merged commit 10a2dc3 into netlify:master Dec 10, 2017
@aureliojargas aureliojargas deleted the patch-3 branch January 5, 2018 22:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants