Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): ignore isPlaying when calling setEnabled #969

Merged
merged 1 commit into from
Sep 23, 2021
+2 −2
Merged

fix(web): ignore isPlaying when calling setEnabled #969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web/flat-web/src/apiMiddleware/rtc/avatar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export class RtcAvatar extends EventEmitter {
this.videoTrack = await this.rtc.getLocalVideoTrack();
console.log("[rtc] got local camera, start play");
this.element && this.videoTrack?.play(this.element);
} else if (this.videoTrack && this.videoTrack.isPlaying !== this.camera) {
} else if (this.videoTrack) {
await (this.videoTrack as ICameraVideoTrack).setEnabled(this.camera);
}
} catch (error) {
Expand Down Expand Up @@ -143,7 +143,7 @@ export class RtcAvatar extends EventEmitter {
console.log("[rtc] got local mic, not play");
// NOTE: play local audio will cause echo
// this.audioTrack.play();
} else if (this.audioTrack && this.audioTrack.isPlaying !== this.mic) {
} else if (this.audioTrack) {
await (this.audioTrack as IMicrophoneAudioTrack).setEnabled(this.mic);
}
} catch (error) {
Expand Down