Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(project): remove unnecessary bootstrap script #1458

Merged
merged 2 commits into from
Mar 31, 2022
Merged

chore(project): remove unnecessary bootstrap script #1458

merged 2 commits into from
Mar 31, 2022

Conversation

hyrious
Copy link
Member

@hyrious hyrious commented Mar 31, 2022

  • docs(readme): add guide to install pnpm

@hyrious
chore(project): remove unnecessary bootstrap script
7825fc9 
- docs(readme): add guide to install pnpm
@hyrious hyrious marked this pull request as ready for review March 31, 2022 02:49
@hyrious hyrious requested a review from BlackHole1 March 31, 2022 02:49
BlackHole1
BlackHole1 requested changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete init-agora-configure

note:

flat/desktop/main-app/scripts/download-agora-addon/patch-download.js

Line 13 in 8acd4d8

require("../../../../scripts/init-agora-configure/agora-electron-options").electron_version;

BlackHole1
BlackHole1 approved these changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BlackHole1 BlackHole1 merged commit c837747 into netless-io:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackHole1 BlackHole1 BlackHole1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyrious @BlackHole1