Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): build script argument invalid #1456

Merged
merged 3 commits into from
Mar 31, 2022
Merged

chore(ci): build script argument invalid #1456

merged 3 commits into from
Mar 31, 2022

Conversation

hyrious
Copy link
Member

@hyrious hyrious commented Mar 31, 2022

  • chore(project): remove "find-up" deps before installing
  • chore(ci): fix build script

@hyrious hyrious changed the title main chore(project): remove "find-up" deps before installing Mar 31, 2022
@hyrious hyrious marked this pull request as ready for review March 31, 2022 02:16
@hyrious hyrious requested a review from BlackHole1 March 31, 2022 02:16
BlackHole1
BlackHole1 requested changes Mar 31, 2022
View reviewed changes
scripts/constants.js Outdated Show resolved Hide resolved
@BlackHole1 BlackHole1 changed the title chore(project): remove "find-up" deps before installing chore(ci): build script argument invalid Mar 31, 2022
BlackHole1
BlackHole1 approved these changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BlackHole1 BlackHole1 merged commit 8acd4d8 into netless-io:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackHole1 BlackHole1 BlackHole1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyrious @BlackHole1