fix(agora): fix rtc element being destroyed

netless-io · Aug 22, 2022 · 61df7f1 · 61df7f1
1 parent 6732791
commit 61df7f1
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 15 deletions.
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/service-providers/agora-rtc/agora-rtc-web/package.json b/service-providers/agora-rtc/agora-rtc-web/package.json
@@ -14,7 +14,7 @@
   },
   "dependencies": {
     "@netless/flat-services": "workspace:*",
-    "agora-rtc-sdk-ng": "^4.12.2",
+    "agora-rtc-sdk-ng": "4.13.0",
     "side-effect-manager": "^1.2.1",
     "value-enhancer": "^1.3.2"
   }

diff --git a/service-providers/agora-rtc/agora-rtc-web/src/agora-rtc-web.ts b/service-providers/agora-rtc/agora-rtc-web/src/agora-rtc-web.ts
@@ -95,8 +95,6 @@ export class AgoraRTCWeb extends IServiceVideoChat {
 
         this.shareScreen.destroy();
 
-        this.sideEffect.flushAll();
-
         await this.leaveRoom();
     }
 
@@ -373,7 +371,6 @@ export class AgoraRTCWeb extends IServiceVideoChat {
                 if (uid === this.shareScreenUID) {
                     if (mediaType === "video") {
                         try {
-                            await client.unsubscribe(user, mediaType);
                             this.shareScreen.setRemoteVideoTrack(null);
                         } catch (e) {
                             console.error(e);
@@ -383,7 +380,6 @@ export class AgoraRTCWeb extends IServiceVideoChat {
                 }
 
                 try {
-                    await client.unsubscribe(user, mediaType);
                     const avatar = this._remoteAvatars.get(uid);
                     if (avatar) {
                         if (mediaType === "audio") {
@@ -395,14 +391,6 @@ export class AgoraRTCWeb extends IServiceVideoChat {
                 } catch (e) {
                     console.error(e);
                 }
-
-                if (!user.videoTrack && !user.audioTrack) {
-                    const avatar = this._remoteAvatars.get(uid);
-                    if (avatar) {
-                        avatar.destroy();
-                        this._remoteAvatars.delete(uid);
-                    }
-                }
             };
             client.on("user-unpublished", handler);
             return () => client.off("user-unpublished", handler);